LED Device Features, Fixes and Refactoring #855

Lord-Grey · 2020-06-29T21:13:57Z

Summary

Features, Fixes and Refactoring around LED Devices

Added

New Devices

Yeelight support incl. device discovery and setup-wizard
WLED as own device and pre-configuration

Additional device related capabilities

discover, getProperties, identify, store/restore state and power-on/off
available for Philips-Hue, Nanoleaf, Yeelight, partially for Rs232 / USB (Hid)
New device capabilities are accessible via JSON-API
New REST-API wrapper class in support of network devices, e.g. Philips Hue, Nanoleaf and WLED
Flexible ssdp-Discovery incl. RegEx matching and filtering

Documentation

Process workflow for LED-Devices
Documentation of device classes & methods
Code template for new LED-Devices available

Changed

LED-Device workflow changed allowing proper suspend/resume & disable/enable scenarios
Network LED-Devices will stop sending packages when disabled
Rs232 Provider fully reworked and changed to synchronous writes
Rs232 configuration via portname and system location (/dev/ style), auto detection is not case-sensitive any longer
Additional error handling depending on device type
Add Windows compatibility incl. moving to Qt functions
Add compatibility for different Qt versions

Fixed

AtomOrb: Buffer length fix and new configuration validations
Added missing DMX SubTypes to configuration
Code clean-ups

What kind of change does this PR introduce? (check at least one)

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

Yes
No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature
Related documents have been updated (docs/docs/en)
Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Resolves #755
Resolves #727
Resolves #859

…on-project#827)

…yperion-project#826) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

# Conflicts: # libsrc/leddevice/dev_net/LedDeviceNanoleaf.cpp # libsrc/leddevice/dev_net/LedDeviceNanoleaf.h # libsrc/leddevice/dev_spi/LedDeviceLpd8806.cpp # libsrc/leddevice/dev_spi/LedDeviceLpd8806.h # libsrc/leddevice/schemas/schema-nanoleaf.json

hyperion-project · 2020-07-03T23:24:38Z

Here is your new link to your workflow artifacts.

tihoangyeudau · 2020-07-04T08:34:26Z

Wled and other udp devices works well but only udpe131 does not work anymore. please check it again

[hyperiond LEDDEVICE] <INFO> Start LedDevice 'udpe131'.
[hyperiond LEDDEVICE] <DEBUG> <LedDevice.cpp:127:LedDevice::init()> deviceConfig: [{"cid":"","colorOrder":"rgb","currentLedCount":105,"hardwareLedCount":105,"host":"192.168.0.144","latchTime":0,"port":5568,"type":"udpe131","universe":1}]
[hyperiond LEDDEVICE] <DEBUG> <ProviderUdp.cpp:48:ProviderUdp::init()> Successfully parsed 192.168.0.144 as an ip address.
[hyperiond LEDDEVICE] <DEBUG> <ProviderUdp.cpp:78:ProviderUdp::init()> UDP using 192.168.0.144:5568[hyperiond ComponentRegister] <DEBUG> <ComponentRegister.cpp:36:ComponentRegister::setNewComponentState()> LED device: disabled

[hyperiond LEDDEVICE] <DEBUG> <LedDeviceUdpE131.cpp:57:LedDeviceUdpE131::init()> e131 no cid found, generated {0c73dd1d-fac9-4784-adeb-a5bb28fac110}

Lord-Grey · 2020-07-04T11:04:34Z

@tihoangyeudau Thanks for testing and confirming the WLED and other UDP Devices work well.
I found the problem on udpe131. When no CID is given and one is generated, I missed to set the device in the state that initialization was done successfully. If you configure a cid (using the one generated "0c73dd1d-fac9-4784-adeb-a5bb28fac110"), the device should work. I am going to fix it later....

tihoangyeudau · 2020-07-04T12:38:58Z

@tihoangyeudau Thanks for testing and confirming the WLED and other UDP Devices work well.
I found the problem on udpe131. When no CID is given and one is generated, I missed to set the device in the state that initialization was done successfully. If you configure a cid (using the one generated "0c73dd1d-fac9-4784-adeb-a5bb28fac110"), the device should work. I am going to fix it later....

yes, thank you for your try. your fork works very smoothly and fastly. Waiting for wled winzart and fixed udpe131

m-seker

Beware that I didn't check functionality as I am not familiar with the component, commented on the style only.

libsrc/leddevice/LedDeviceWrapper.cpp

libsrc/leddevice/dev_hid/LedDeviceMultiLightpack.cpp

libsrc/leddevice/dev_hid/LedDeviceMultiLightpack.h

libsrc/leddevice/dev_net/LedDeviceWled.cpp

libsrc/leddevice/dev_net/LedDeviceYeelight.cpp

libsrc/leddevice/dev_net/ProviderRestApi.cpp

Lord-Grey · 2020-07-05T10:10:59Z

@tihoangyeudau Thanks for testing and confirming the WLED and other UDP Devices work well.
I found the problem on udpe131. When no CID is given and one is generated, I missed to set the device in the state that initialization was done successfully. If you configure a cid (using the one generated "0c73dd1d-fac9-4784-adeb-a5bb28fac110"), the device should work. I am going to fix it later....

yes, thank you for your try. your fork works very smoothly and fastly. Waiting for wled winzart and fixed udpe131

@tihoangyeudau Fix is available.

tihoangyeudau · 2020-07-05T13:06:28Z

Ok bro

hyperion-project · 2020-07-07T20:12:51Z

Here is your new link to your workflow artifacts.

hyperion-project · 2020-07-09T21:52:20Z

Here is your new link to your workflow artifacts.

hyperion-project · 2020-07-11T08:11:17Z

Here is your new link to your workflow artifacts.

hyperion-project · 2020-07-11T08:16:45Z

Here is your new link to your workflow artifacts.

Paulchen-Panther · 2020-07-12T07:17:28Z

Wolltest du hier noch aufräumen oder ist dieser PR fertig?

# Conflicts: # include/leddevice/LedDevice.h # libsrc/leddevice/LedDeviceTemplate.cpp # libsrc/leddevice/LedDeviceTemplate.h # libsrc/leddevice/dev_hid/LedDeviceMultiLightpack.cpp # libsrc/leddevice/dev_net/LedDeviceAtmoOrb.cpp # libsrc/leddevice/dev_net/LedDeviceNanoleaf.cpp

hyperion-project · 2020-07-12T09:03:58Z

Here is your new link to your workflow artifacts.

This reverts commit 978ac75, reversing changes made to aa346ed.

hyperion-project · 2020-07-12T09:13:23Z

Here is your new link to your workflow artifacts.

Lord-Grey and others added 30 commits June 8, 2020 20:52

Refactor LedDevices - Initial version

a89d3d6

Small renamings

8c7a5b5

Add WLED as own device

1ae100c

Lpd8806 Remove open() method

7e23086

remove dependency on Qt 5.10

5109140

Lpd8806 Remove open() method

d53cbd7

Update WS281x

6b9c532

Update WS281x

a92c2e6

Update WS2812SPI

f42470e

Add writeBlack for WLED powerOff

b2e26cf

WLED remove extra bracket

9908cb8

Allow different Nanoleaf panel numbering sequence (Feature req.hyperi…

96cc580

…on-project#827)

Allow different Nanoleaf panel numbering sequence (Feature req.hyperi…

771f7bd

…on-project#827)

Merge remote-tracking branch 'upstream/master'

f948922

Fix typos

aa94dcc

Nanoleaf clean-up

b3b8966

Yeelight support, generalize wizard elements

f87b178

Update Yeelight to handle quota in music mode

2841601

Yeelight extend rage for extraTimeDarkness for testing

e9dfd19

Clean-up - Add commentary, Remove development debug statements

7f02d7e

Fix brightnessSwitchOffOnMinimum typo and default value

d97d0be

Yeelight support restoreOriginalState, additional Fixes

7e1966d

WLED - Remove UDP-Port, as it is not configurable

f8b845a

Merge remote-tracking branch 'upstream/master'

8b85e5d

Fix merging issue

5f718fa

Remove QHostAddress::operator=(const QString&)' is deprecated

15917ce

Windows compile errors and (Qt 5.15 deprecation) warnings

edbfa56

Fix order includes

efd8043

Fixes and Clean-up after clang-tidy report

5ffd10c

m-seker approved these changes Jul 4, 2020

View reviewed changes

Fix udpe131 not enabled for generated CID

898a7aa

Lord-Grey mentioned this pull request Jul 5, 2020

Serial device detection broken on Linux #865

Closed

1 task

Lord-Grey added 2 commits July 7, 2020 20:39

Change timer into dynamic for Qt Thread-Affinity

4f33d62

Hue clean-up and diyHue workaround

a0a59b0

Updates after review feedback by m-seker

a5a1707

m-seker approved these changes Jul 9, 2020

View reviewed changes

Add "chrono" includes

36c14af

Add "chrono" includes

aa346ed

Lord-Grey added 2 commits July 12, 2020 10:47

Merge remote-tracking branch 'upstream/master'

1e93a73

Revert "Merge branch 'master' into Refactor_LedDevices"

bd1ea3a

This reverts commit 978ac75, reversing changes made to aa346ed.

Paulchen-Panther approved these changes Jul 12, 2020

View reviewed changes

Paulchen-Panther merged commit 8eb5619 into hyperion-project:master Jul 12, 2020

Lord-Grey mentioned this pull request Jul 12, 2020

LED Device Features, Fixes and Refactoring (Resubmit PR855) #875

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LED Device Features, Fixes and Refactoring #855

LED Device Features, Fixes and Refactoring #855

Lord-Grey commented Jun 29, 2020 •

edited

Loading

hyperion-project bot commented Jul 3, 2020

tihoangyeudau commented Jul 4, 2020 •

edited

Loading

Lord-Grey commented Jul 4, 2020

tihoangyeudau commented Jul 4, 2020 •

edited

Loading

m-seker left a comment

Lord-Grey commented Jul 5, 2020 •

edited

Loading

tihoangyeudau commented Jul 5, 2020

hyperion-project bot commented Jul 7, 2020

hyperion-project bot commented Jul 9, 2020

hyperion-project bot commented Jul 11, 2020

hyperion-project bot commented Jul 11, 2020

Paulchen-Panther commented Jul 12, 2020

hyperion-project bot commented Jul 12, 2020

hyperion-project bot commented Jul 12, 2020

LED Device Features, Fixes and Refactoring #855

LED Device Features, Fixes and Refactoring #855

Conversation

Lord-Grey commented Jun 29, 2020 • edited Loading

Added

Changed

Fixed

hyperion-project bot commented Jul 3, 2020

tihoangyeudau commented Jul 4, 2020 • edited Loading

Lord-Grey commented Jul 4, 2020

tihoangyeudau commented Jul 4, 2020 • edited Loading

m-seker left a comment

Choose a reason for hiding this comment

Lord-Grey commented Jul 5, 2020 • edited Loading

tihoangyeudau commented Jul 5, 2020

hyperion-project bot commented Jul 7, 2020

hyperion-project bot commented Jul 9, 2020

hyperion-project bot commented Jul 11, 2020

hyperion-project bot commented Jul 11, 2020

Paulchen-Panther commented Jul 12, 2020

hyperion-project bot commented Jul 12, 2020

hyperion-project bot commented Jul 12, 2020

Lord-Grey commented Jun 29, 2020 •

edited

Loading

tihoangyeudau commented Jul 4, 2020 •

edited

Loading

tihoangyeudau commented Jul 4, 2020 •

edited

Loading

Lord-Grey commented Jul 5, 2020 •

edited

Loading